Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2321R2: views::adjacent_transform, views::pairwise_transform #3546

Merged
merged 14 commits into from
Mar 17, 2023

Conversation

JMazurkiewicz
Copy link
Contributor

@JMazurkiewicz JMazurkiewicz commented Mar 7, 2023

Closes #2252. Implemented features:

TODO
  • Reduce and report Clang bug marked in the code with LLVM-?. Current repro:
    #include <ranges>
    
    auto sum = [](auto... vals) { return (vals + ...); };
    int vals[] = {1, 2, 3, 4, 5};
    auto v = std::views::adjacent_transform<3>(vals, sum);
    There is no need to report this bug, it's been fixed in Clang 16: https://godbolt.org/z/815f371Wc.
  • Reduce and report MSVC bug: _Invoke_result_with_repeated_type_impl had to be implemented as a recursive template (using index sequence caused ICE). See DevCom-10302378,
  • More tests.

@JMazurkiewicz JMazurkiewicz changed the title Adjacent transform P2321R2: views::adjacent_transform, views::pairwise_transform Mar 7, 2023
@StephanTLavavej StephanTLavavej added ranges C++20/23 ranges cxx23 C++23 feature labels Mar 7, 2023
@JMazurkiewicz JMazurkiewicz marked this pull request as ready for review March 7, 2023 15:28
@JMazurkiewicz JMazurkiewicz requested a review from a team as a code owner March 7, 2023 15:28
@JMazurkiewicz

This comment was marked as outdated.

@fsb4000

This comment was marked as resolved.

stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
stl/inc/ranges Outdated Show resolved Hide resolved
tests/std/tests/P2321R2_views_adjacent_transform/test.cpp Outdated Show resolved Hide resolved
tests/std/tests/P2321R2_views_adjacent_transform/test.cpp Outdated Show resolved Hide resolved
@StephanTLavavej

This comment was marked as resolved.

@JMazurkiewicz

This comment was marked as resolved.

@StephanTLavavej

This comment was marked as resolved.

Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor request; will push changes.

never mind.

stl/inc/ranges Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 56a65e0 into microsoft:main Mar 17, 2023
@StephanTLavavej
Copy link
Member

Thanks to you, @cpplearner, and @tylerbrawl, the zip paper is now complete! Thank you all!

😻 🤐 🚀

@JMazurkiewicz JMazurkiewicz deleted the adjacent_transform branch March 17, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cxx23 C++23 feature ranges C++20/23 ranges
Projects
None yet
Development

Successfully merging this pull request may close these issues.

P2321R2 zip
5 participants