Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use symbolic constants in implementation of stacktrace #3292

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Use symbolic constants in implementation of stacktrace #3292

merged 1 commit into from
Jan 11, 2023

Conversation

CaseyCarter
Copy link
Contributor

... to avoid errors.

Fixes #3283

@CaseyCarter CaseyCarter added the bug Something isn't working label Dec 15, 2022
@CaseyCarter CaseyCarter requested a review from a team as a code owner December 15, 2022 23:45
@StephanTLavavej StephanTLavavej self-assigned this Jan 11, 2023
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 642303b into microsoft:main Jan 11, 2023
@StephanTLavavej
Copy link
Member

Thanks for fixing this bug and preventing further occurrences! 🐞 🛠️ 🩹

@CaseyCarter CaseyCarter deleted the symbolic branch January 11, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@strega-nil-ms strega-nil-ms strega-nil-ms approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<stacktrace>: SYMOPT_FAIL_CRITICAL_ERRORS has incorrect value
3 participants
@CaseyCarter @StephanTLavavej @strega-nil-ms