Move barrier macros from <atomic> to <xatomic.h>
#3124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But I guess they should be still `#undef`ed in `<atomic>`.
Strangely, some failures occured in formerly verified portions.
frederick-vs-ja
commented
Sep 23, 2022
And mention <memory> in <xatomic.h>.
|
I really don't like this split of the |
|
The lack of undefs would normally break what's in vcruntime, however, that stuff is all C only, and the header will |
barcharcraz
approved these changes
Oct 15, 2022
StephanTLavavej
approved these changes
Oct 19, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for reorganizing this atomics code! ☢️ 😹 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3048.
@MattStephanson @barcharcraz
I think we can include
<xatomic.h>inlocale0.cpponce this PR gets merged as<xatomic.h>has been made a core header, and avoid the third copy of these macro definitions. This should have no undesired impact on the size of import library.I guess these macros should still be#undefed in<atomic>, so I copied the comments in<atomic>with modifications.The separated
#undefdirectives in<atomic>are being removed.