Suppress narrowing warnings in piecewise_constant_distribution::densities
#3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This didn't actually suppress the warnings... |
TFWU commit the tests but not the bugfix. 🤦 |
…ties This function converts a `vector` of `double` to a `vector` of `_Ty`, which is a narrowing conversion when `Ty` is `float`. It's silly to warn about this when the Standard makes it clear that the narrowing will occur, and the user has asked for such explicitly by calling `piecewise_constant_distrubution<float>::densities`. Fixes microsoft#3105.
|
I'll rebase onto the updated |
CaseyCarter
force-pushed
the
part-foolish
branch
from
c19243e to
feaed49
Compare
strega-nil-ms
approved these changes
Sep 19, 2022
StephanTLavavej
approved these changes
Sep 21, 2022
|
@CaseyCarter @strega-nil-ms I have doubled the size of this PR 😹 🛠️ and converted the test to compile-only. ✅ No modules impact - the push-disable-pops are outside the member functions which is good. |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
StephanTLavavej
changed the title
piecewise_constant_distrubution::densitiespiecewise_constant_distribution::densities
|
Thanks for investigating and fixing these spurious warnings! |
CaseyCarter
added a commit
to CaseyCarter/STL
that referenced
this pull request
Oct 6, 2022
…ities` (microsoft#3107) Co-authored-by: Stephan T. Lavavej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function converts a
vectorofdoubleto avectorof_Ty, which is a narrowing conversion whenTyisfloat. It's silly to warn about this when the Standard makes it clear that the narrowing will occur, and the user has asked for such explicitly by callingpiecewise_constant_distrubution<float>::densities.Fixes #3105.