-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore rule-sets warning #3081
ignore rule-sets warning #3081
Conversation
This PR intends to suppress 40 kinds of warnings. However, none of the related problematic cases is described in the PR at this moment. Are these warnings triggered within MSVC STL's headers? Have you tried to suppress them before including STL's headers and then unsuppress them after including? |
These warnings came after I directly included |
Tests fail because #2908 , it is not related to your PR. |
If anyone needs it, here are the details of stl's warning content |
Thanks for looking into this! We talked about this at the weekly maintainer meeting - these warnings do appear to be largely spurious for the STL (for various reasons - e.g. we can't use the GSL because the GSL depends on us! 😹). However, we would want to individually verify that each of these warnings is definitely spurious before silencing them for the STL forever, and 40 warnings is a lot to look into. We're going to close this PR without merging it, because we've already implemented a solution for projects like yours that are experiencing warnings in STL code. If you define Lines 667 to 669 in f9697fc
Lines 697 to 708 in f9697fc
Hope this helps! |
I clone the STL git repository locally and add it to my header path, but since I often have all the c++ rulesets open, the STL library headers become a big num of warnings in my project (providing 1000+ warnings) and I don't know how to ignore it.
This PR fixes that problem