Don't deallocate nullptr in _Hash_vec::_Tidy #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaseyCarter
commented
Jun 13, 2022
... since we probably didn't get `nullptr` from an allocator, and user-defined allocators aren't required to tolerate dellocating `nullptr`. Fixes microsoft#2789.
StephanTLavavej
approved these changes
Jun 14, 2022
|
Looks good, I pushed trivial changes to the test. |
miscco
approved these changes
Jun 14, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for tidying up this bug! 🐞 🧹 😹 |
fsb4000
pushed a commit
to fsb4000/STL
that referenced
this pull request
Aug 13, 2022
Co-authored-by: Stephan T. Lavavej <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... since we probably didn't get
nullptrfrom an allocator, and user-defined allocators aren't required to tolerate dellocatingnullptr.Fixes #2789.