Scalarize swap and ranges::swap for arrays
#2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 39332e1.
This was a race condition between GH 2433 and GH 2666.
CaseyCarter
approved these changes
May 3, 2022
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2699 by reverting #2689. I have reopened #2683.
Add test coverage for the regression to
GH_001411_core_headers. I'm renaming it totest.cppbecause I want it to link and run, and I'm dropping the part about "Non-core headers like<chrono>should include<yvals.h>." (as this is uninteresting).Drive-by fix: Add comment to
test_gh_2618()inDev11_0836436_get_time. This was a race condition between #2433 and #2666.