Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split <chrono> into <__msvc_chrono.hpp> #2604

Merged
merged 3 commits into from
Mar 19, 2022

Conversation

StephanTLavavej
Copy link
Member

This contains @cpplearner's commits in #2600 to split <chrono> into a smaller internal header containing classic machinery (a strategy used successfully in the past), with an additional commit to rename this header to follow our modern naming convention.

(<__msvc_meow.hpp> clearly indicates "internal, implementation-specific, not for public consumption", and all recently added headers have followed that pattern. <xmeow.h> is less obviously internal. We don't use extensionless <xmeow> anymore because that requires changing the IDE's lists of extensionless headers.)

This is a separate PR because we want to prioritize the header surgery for VS 2022 17.2 Preview 3 (low risk, high throughput gain). Thanks again to @cpplearner who did all the hard work here - I reviewed the split to make sure nothing was lost or altered unintentionally. (The only thing being dropped with a single comment // [time.clock.file], which I'm perfectly happy with.)

Works towards #2003.

⚠️ Note when merging:

Microsoft-internal build/setup changes will be necessary for this new header.

@StephanTLavavej StephanTLavavej added throughput Must compile faster chrono C++20 chrono labels Mar 9, 2022
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner March 9, 2022 01:18
@StephanTLavavej StephanTLavavej added the high priority Important! label Mar 9, 2022
@barcharcraz barcharcraz removed their assignment Mar 9, 2022
@StephanTLavavej StephanTLavavej added blocked Something is preventing work on this and removed high priority Important! labels Mar 10, 2022
@StephanTLavavej

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej removed the blocked Something is preventing work on this label Mar 17, 2022
@StephanTLavavej StephanTLavavej self-assigned this Mar 18, 2022
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chrono C++20 chrono throughput Must compile faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants