Split <chrono>
into <__msvc_chrono.hpp>
#2604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains @cpplearner's commits in #2600 to split
<chrono>
into a smaller internal header containing classic machinery (a strategy used successfully in the past), with an additional commit to rename this header to follow our modern naming convention.(
<__msvc_meow.hpp>
clearly indicates "internal, implementation-specific, not for public consumption", and all recently added headers have followed that pattern.<xmeow.h>
is less obviously internal. We don't use extensionless<xmeow>
anymore because that requires changing the IDE's lists of extensionless headers.)This is a separate PR because we want to prioritize the header surgery for VS 2022 17.2 Preview 3 (low risk, high throughput gain). Thanks again to @cpplearner who did all the hard work here - I reviewed the split to make sure nothing was lost or altered unintentionally. (The only thing being dropped with a single comment
// [time.clock.file]
, which I'm perfectly happy with.)Works towards #2003.
Microsoft-internal build/setup changes will be necessary for this new header.