Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untag dispatch regex #2484

Merged
merged 5 commits into from
Mar 19, 2022
Merged

Conversation

AlexGuteniev
Copy link
Contributor

Towards #189
Separated from #2219

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner January 16, 2022 14:28
stl/inc/regex Outdated Show resolved Hide resolved
@StephanTLavavej StephanTLavavej added the throughput Must compile faster label Jan 16, 2022
stl/inc/regex Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter self-assigned this Feb 23, 2022
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicky cosmetic things; I'll push changes.

stl/inc/regex Outdated Show resolved Hide resolved
stl/inc/regex Outdated Show resolved Hide resolved
stl/inc/regex Outdated Show resolved Hide resolved
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit b973fd0 into microsoft:main Mar 19, 2022
@AlexGuteniev AlexGuteniev deleted the untag_dispatch_regex branch March 19, 2022 09:58
@StephanTLavavej
Copy link
Member

Thanks for <regex> replacing this tag dispatch with if constexpr! 😹 😻 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
throughput Must compile faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants