Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<filesystem>: path should be range #2457

Merged
merged 14 commits into from
Mar 28, 2022
Merged

<filesystem>: path should be range #2457

merged 14 commits into from
Mar 28, 2022

Conversation

fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Jan 4, 2022

Fixes #2358

@fsb4000 fsb4000 requested a review from a team as a code owner January 4, 2022 14:56
AlexGuteniev
AlexGuteniev reviewed Jan 4, 2022
View reviewed changes
stl/inc/filesystem Outdated Show resolved Hide resolved
AlexGuteniev
AlexGuteniev reviewed Jan 4, 2022
View reviewed changes
stl/inc/filesystem Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter added bug Something isn't working ranges C++20/23 ranges labels Jan 6, 2022
CaseyCarter
CaseyCarter approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed changes for my comments, which are a bit more invasive than I'd typically do in someone's branch without asking. Feel free to pushback if you disagree with anything.

stl/inc/filesystem Outdated Show resolved Hide resolved
stl/inc/filesystem Outdated Show resolved Hide resolved
@CaseyCarter CaseyCarter removed their assignment Mar 24, 2022
@StephanTLavavej

This comment was marked as resolved.

Sign in to view
@azure-pipelines

This comment was marked as resolved.

Sign in to view
1 similar comment
@azure-pipelines

This comment was marked as resolved.

Sign in to view
@StephanTLavavej StephanTLavavej self-assigned this Mar 25, 2022
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit c302187 into microsoft:main Mar 28, 2022
@StephanTLavavej
Copy link
Member

Thanks for fixing path to behave properly after this surprising interaction with C++23! 😻 🚀 ✅

@fsb4000 fsb4000 deleted the fix2358 branch March 29, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexGuteniev AlexGuteniev AlexGuteniev left review comments

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
bug Something isn't working ranges C++20/23 ranges
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<filesystem>: path's comparison operators are IF-NDR
4 participants
@fsb4000 @StephanTLavavej @CaseyCarter @AlexGuteniev