-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<any>: std::any links when exceptions are disabled #2193
Conversation
After looking at this, I agree that the change is correct and ABI-safe. Usually, anything mentioning I have verified this by inspecting the DLL's exports (these types don't appear), and by performing an internal build of the STL with #if !_HAS_EXCEPTIONS
#if defined(CRTDLL2) && defined(_CRTBLD)
#error WOOF
#endif
// ... here; it succeeded, proving that these are indeed never exported. |
I'm (speculatively) mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
tests/std/tests/GH_000990_any_link_without_exceptions/test.compile.pass.cpp
Outdated
Show resolved
Hide resolved
Thanks for fixing this long-standing bug! 😻 🐞 🎉 |
Co-authored-by: Stephan T. Lavavej <[email protected]>
Fixes #990