Port MSVC-internal changes, again #1431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barcharcraz
reviewed
Nov 7, 2020
barcharcraz
approved these changes
Nov 7, 2020
cbezault
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1344 (see that PR for an explanation of ARM64EC).
This ports Microsoft-internal MSVC-PR-286340, which merged accumulated work from the compiler back-end team in their
prod/beMSVC branch. After applying thegit diff --binarypatch with no conflicts or manual edits, I verified that the GitHub and MSVC repos are binary-identical. (Note that I did not copy-overwrite, which would pick up unintentional divergence; this was a proper patch, as always.)My vague understanding of these changes is:
stl/aliaseschanges are related to special name mangling for ARM64EC (I think that's the#symbol).stl/msbuildmachinery for ARM64EC is being removed, but the changes look mechanically correct to me, less machinery is better, and if the compiler devs are happy with what's being built for ARM64EC (as part of the main arm64 build), I'm happy. 😸