Skip to content

Conversation

@miscco
Copy link
Contributor

@miscco miscco commented Oct 16, 2020

There was a leftover from #1164 where I forgot to remove the unneeded specialization from uninitialized_default_construct_n

@miscco miscco requested a review from a team as a code owner October 16, 2020 13:25
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Oct 16, 2020
@StephanTLavavej StephanTLavavej changed the title Remove unneeded specialization in uninitialized_default_construct_n Remove unneeded case in uninitialized_default_construct_n Oct 16, 2020
@StephanTLavavej
Copy link
Member

Thanks, seems reasonable to me. To verify my understanding - this isn't needed because the "general" case below handles it, and there's no significant savings from avoiding construction of the backout-guard when no exceptions are possible.

I changed the PR title because "specialization" has a very specialized meaning when one works with templates all day, every day ("case" also has a specific meaning but it doesn't strongly connote "switch statement" 😹).

@CaseyCarter
Copy link
Contributor

To verify my understanding - this isn't needed because the "general" case below handles it, and there's no significant savings from avoiding construction of the backout-guard when no exceptions are possible.

Yes, that's it exactly. There were cases like this in many of the algorithms at one point, which @miscco removed after some investigation showed that it didn't significantly affect codegen.

@StephanTLavavej StephanTLavavej self-assigned this Oct 17, 2020
@StephanTLavavej StephanTLavavej merged commit 39eb812 into microsoft:master Oct 17, 2020
@StephanTLavavej
Copy link
Member

Thanks for this small cleanup! 🐈

@miscco miscco deleted the fix_uninitialized_default_construct branch October 23, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants