Replace 0 with nullptr where appropriate #1250
Conversation
| if (GetFileAttributesExW(_Fname, GetFileExInfoStandard, &_Data)) { | ||
| // get file type and return permissions | ||
| if (_Pmode != 0) { | ||
| if (_Pmode != nullptr) { |
There was a problem hiding this comment.
Should we use conversion to bool here, aka if (_Pmode)?
Would apply throughout
There was a problem hiding this comment.
Our codebase is currently inconsistent about testing pointers directly (or negated), versus comparing them to nullptr. (Unlike integers, where we strongly prefer to explicitly compare them against zero.) I personally like directly testing pointers, because I believe it reads naturally ("if we have pointer, do cool things with it") and avoids the double negation inherent in "not null". However, I think that if we want to consistently test pointers directly, we should do so as a separate cleanup change.
StephanTLavavej
left a comment
StephanTLavavej
left a comment
There was a problem hiding this comment.
Looks good, thanks! I think this will be ready to check in after making clang-format happy, and changing the _CRT_APP codepath for symmetry (this is not currently built in the GitHub repo but will be in the future).
CaseyCarter
changed the title
|
Thanks for the cleanup! |
4 participants
These were found with clang.