Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up comments for LWG-3912 enumerate_view::iterator::operator- should be noexcept #3780

Closed
frederick-vs-ja opened this issue Jun 17, 2023 · 0 comments · Fixed by #3784
Closed

Clean up comments for LWG-3912 enumerate_view::iterator::operator- should be noexcept #3780

frederick-vs-ja opened this issue Jun 17, 2023 · 0 comments · Fixed by #3784
Labels
documentation Related to documentation or comments fixed Something works now, yay! good first issue Good for newcomers

Comments

@frederick-vs-ja
Copy link
Contributor

LWG-3912 has been voted into the standard, so we should remove the following /* strengthened */ comment.

Code:

STL/stl/inc/ranges

Lines 6126 to 6129 in 15aea98

_NODISCARD_FRIEND constexpr difference_type operator-(
const _Iterator& _Left, const _Iterator& _Right) noexcept /* strengthened */ {
return _Left._Pos - _Right._Pos;
}

Please feel free to submit a pull request if there isn't one already linked here - no need to ask for permission! 😸

You can (and should) link your pull request to this issue using GitHub's close/fix/resolve syntax.
@frederick-vs-ja frederick-vs-ja mentioned this issue Jun 17, 2023
Closed
17 tasks
@StephanTLavavej StephanTLavavej added documentation Related to documentation or comments good first issue Good for newcomers labels Jun 17, 2023
@JacobOgle JacobOgle mentioned this issue Jun 19, 2023
Merged
StephanTLavavej pushed a commit that referenced this issue Jun 22, 2023
@JacobOgle
Documentation Fix for #3780 (#3784)
9e07371
@StephanTLavavej StephanTLavavej added the fixed Something works now, yay! label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Related to documentation or comments fixed Something works now, yay! good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Documentation Fix for #3780
2 participants
@StephanTLavavej @frederick-vs-ja