Added AARCH64 support #136
Open
+276
−226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@mcelhennyi I noticed that there are conflicts with the latest commit of the master branch, would you mind rebasing it? I'm considering adding it to the Debian package of SPTAG. |
|
@pabs3 I have actually stopped using SPTAG. So I won’t be able to rebase and test. Sorry about that. |
|
Merging this issue will also fix #316 too. |
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jul 12, 2022
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jul 12, 2022
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Blocked-by: simd-everywhere/simde#961
|
I tried to create a new patch but SPTAG now uses AVX512 and SIMDe is missing three functions and is missing three native aliases (useful to avoid having to change lots of the code), the missing aliases is easily worked around though. simd-everywhere/simde#961 |
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jul 18, 2022
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Blocked-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jul 26, 2022
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Blocked-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Nov 13, 2022
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Blocked-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Feb 5, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Blocked-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Mar 1, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Blocked-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Mar 25, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Blocked-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Apr 1, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Blocked-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
May 3, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Blocked-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
May 10, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Blocked-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
May 10, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
May 10, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
May 11, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
May 11, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
May 11, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
May 11, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jun 16, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jun 16, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jun 16, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jun 16, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jun 16, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jun 25, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jun 25, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jun 25, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jun 25, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jun 27, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jun 27, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jun 27, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jun 27, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jul 20, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jul 20, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jul 20, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jul 20, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
pabs3
added a commit
to pabs3/SPTAG
that referenced
this pull request
Jul 20, 2023
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
dbussink
pushed a commit
to planetscale/SPTAG
that referenced
this pull request
Mar 13, 2024
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
dbussink
pushed a commit
to planetscale/SPTAG
that referenced
this pull request
Mar 14, 2024
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961
dbussink
pushed a commit
to planetscale/SPTAG
that referenced
this pull request
Mar 14, 2024
Obsoletes: microsoft#136 Fixes: microsoft#134 Fixes: microsoft#316 Enabled-by: simd-everywhere/simde#961 Signed-off-by: Dirkjan Bussink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request would allow for AARCH64 support. I made sure the ./test executable can run without error on an arm docker.
The only thing I am unsure of is the use of __builtin_prefetch. SIMDe supports prefetch commands, but I am unsure how to map the enum over to SIMDe from the original use. Currently I have just used the __builtin_prefetch version in place of the __mm_prefetch.