-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Driver/Tektronix AWG5208 #977
Conversation
Codecov Report
@@ Coverage Diff @@
## master #977 +/- ##
==========================================
+ Coverage 78.6% 78.62% +0.01%
==========================================
Files 45 45
Lines 6423 6423
==========================================
+ Hits 5049 5050 +1
+ Misses 1374 1373 -1 |
I would call this a working driver. @sohailc, what do you say? |
Let me have a look at this latet this afternoon
…On Feb 23, 2018 1:22 PM, "William H.P. Nielsen" ***@***.***> wrote:
I would call this a working driver. @sohailc <https://github.com/sohailc>,
what do you say?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#977 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AJ-GjI_LrSPSYrxa702gi6V46sgv_fgKks5tXq2ZgaJpZM4SN4p0>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to land. We can always add more features as we go. Only question is if we should deprecate the other driver now?
@jenshnielsen Let's deprecate it now. Or even remove it. We have intelligence saying that no one is using that driver. |
Author: William H.P. Nielsen <[email protected]> Driver/Tektronix AWG5208 (#977)
Changes proposed in this pull request:
Note that we have an AWG5200 driver that subclasses the 5014 driver. This file should probably be deleted, as the software is very different on those two AWGs, and noone seems to be using that driver (@peendebak, do you confirm/agree?).
Work items:
@sohailc @jenshnielsen