-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DelegateParameters inherit their source's settable/gettable/snapshot_value/unit/label #6648
DelegateParameters inherit their source's settable/gettable/snapshot_value/unit/label #6648
Conversation
@jenshnielsen Not sure if this is a big enough issue to rethink the implementation. What are your thoughts? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6648 +/- ##
==========================================
+ Coverage 69.35% 69.37% +0.01%
==========================================
Files 340 340
Lines 31303 31322 +19
==========================================
+ Hits 21710 21729 +19
Misses 9593 9593 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
b0a2781
to
a1752ba
Compare
d60d310
to
1c89455
Compare
This PR fixes a bug observed when chaining multiple DelegateParameters, and changing the source at the bottom of the chain.
In the previous implementation, a DelegateParameter only updated it's internal
_settable
and_gettable
attributes when thesource
was changed. But it is possible to set up a chain of DelegateParameters and then change the 'root' source Parameter. This updates the bottom-most DelegateParameter, but all of the other DelegateParameters in the chain will not update.This PR changes the implementation to override the
ParameterBase
implementation of thegettable
andsettable
properties, so that they reflect the underlyingsource
parameter, no matter what it may be.