Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curve header parameters to Lakeshore model 336, make group parameter take callable get_cmd #6520

Merged

Conversation

simonschaal
Copy link
Contributor

This driver update adds parameters to the Lakeshore 336 channel that allows query of the input channel curve header to read from the instrument:

  • input_curve_number
  • input_curve_name
  • input_curve_sn
  • input_curve_format
  • input_curve_limit
  • input_curve_coefficient

This is useful to verify remotely if the correct temperature calibration curve is selected.

@simonschaal simonschaal requested a review from a team as a code owner October 11, 2024 23:01
@astafan8 astafan8 enabled auto-merge October 14, 2024 13:15
@simonschaal
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@astafan8 astafan8 changed the title Add curve input parameters to Lakeshore_model_336.py Add curve header parameters to Lakeshore model 336, make group parameter take callable get_cmd Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.33%. Comparing base (d4e1e15) to head (5a2e4d8).
Report is 36 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6520   +/-   ##
=======================================
  Coverage   69.33%   69.33%           
=======================================
  Files         340      340           
  Lines       31240    31261   +21     
=======================================
+ Hits        21659    21676   +17     
- Misses       9581     9585    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astafan8 astafan8 added this pull request to the merge queue Oct 14, 2024
Merged via the queue into microsoft:main with commit c3f3d07 Oct 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants