Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samanthaho/registered parameter snapshot #6487

Merged

Conversation

samantha-ho
Copy link
Contributor

@samantha-ho samantha-ho commented Oct 4, 2024

This PR adds a new category to the dataset snapshot. Previously, when a qcodes Measurement ran, only the station snapshot was saved. The parameters directly involved in the measurement were not explicitly snapshotted, and if those parameters were not part of the station, metadata about them could be lost.

The dataset snapshot dictionary now contains a new top-level key, "parameters" in addition to the original "station" key. Under parameters, there are snapshots of all parameters registered in the Measurement.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.33%. Comparing base (07080a8) to head (7ebd8ba).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
src/qcodes/dataset/measurements.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6487   +/-   ##
=======================================
  Coverage   69.32%   69.33%           
=======================================
  Files         340      340           
  Lines       31226    31240   +14     
=======================================
+ Hits        21648    21659   +11     
- Misses       9578     9581    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samantha-ho samantha-ho marked this pull request as ready for review October 7, 2024 20:49
@samantha-ho samantha-ho requested a review from a team as a code owner October 7, 2024 20:49
Copy link
Contributor

@trevormorgan trevormorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

src/qcodes/dataset/measurements.py Outdated Show resolved Hide resolved
@samantha-ho samantha-ho added this pull request to the merge queue Oct 10, 2024
Merged via the queue into microsoft:main with commit 269ef97 Oct 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants