-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samanthaho/registered parameter snapshot #6487
Samanthaho/registered parameter snapshot #6487
Conversation
…snapshot Add parameters to snapshot passed to prepare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6487 +/- ##
=======================================
Coverage 69.32% 69.33%
=======================================
Files 340 340
Lines 31226 31240 +14
=======================================
+ Hits 21648 21659 +11
- Misses 9578 9581 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition!
…rrors have already happened
…thub.com/samantha-ho/Qcodes into samanthaho/registered-parameter-snapshot
This PR adds a new category to the dataset snapshot. Previously, when a qcodes Measurement ran, only the station snapshot was saved. The parameters directly involved in the measurement were not explicitly snapshotted, and if those parameters were not part of the station, metadata about them could be lost.
The dataset snapshot dictionary now contains a new top-level key, "parameters" in addition to the original "station" key. Under parameters, there are snapshots of all parameters registered in the Measurement.