Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typeing of dond #6426

Merged

Conversation

jenshnielsen
Copy link
Collaborator

The overload introduced in #6422 did not correctly match on all instances where either squeeze was not given or a bool. This fixes that

@jenshnielsen jenshnielsen requested a review from a team as a code owner September 9, 2024 06:20
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.29%. Comparing base (a0c2bd0) to head (5aeb362).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6426   +/-   ##
=======================================
  Coverage   67.29%   67.29%           
=======================================
  Files         352      352           
  Lines       32163    32165    +2     
=======================================
+ Hits        21645    21647    +2     
  Misses      10518    10518           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen added this pull request to the merge queue Sep 9, 2024
Merged via the queue into microsoft:main with commit 9407788 Sep 9, 2024
16 checks passed
@jenshnielsen jenshnielsen deleted the jenshnielsen/fix_dond_type branch September 9, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants