feat: add loop.plot() #637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add loop.plot() method, which automatically attaches it to the background task of the loop. Currently only works with MatPlot, not sure how to make it know when to choose QTPlot
|
@nulinspiratie (also @WilliamHPNielsen @jenshnielsen @giulioungaretti ) |
|
is this PR still relevant and useful? :) |
Codecov Report
@@ Coverage Diff @@
## master #637 +/- ##
=========================================
- Coverage 67.21% 67.2% -0.01%
=========================================
Files 145 145
Lines 17951 17956 +5
=========================================
+ Hits 12065 12068 +3
- Misses 5886 5888 +2 |
|
I think it's fair to close this PR, since we'll do no further development of the old loop. |
|
Agreed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #issuenumber.
Changes proposed in this pull request:
Add loop.plot() method to ActiveLoop, which automatically attaches it to the task of the loop. It cleans up the measurement code, as you can now use a single line
loop.plot(data_set.data_vals)instead of:When combined with PR #636 , it becomes especially easy to create a plot with multiple subplots using a single readable line.
I didn't add it to Loop, but only to ActiveLoop. I'm not sure why we have both, is it also needed in Loop?
Currently only works with MatPlot, as I'm not sure to determine when to use MatPlot, and when to use QTPlot
@giulioungaretti @WilliamHPNielsen @jenshnielsen