Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMI430 cleanup #6306

Merged
merged 7 commits into from
Aug 8, 2024
Merged

AMI430 cleanup #6306

merged 7 commits into from
Aug 8, 2024

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Aug 2, 2024

  • Don't trigger warnings when snapshotting a AMI430 without an enabled switch heater
  • Deprecate confusing setter/getter methods that duplicate parameters
  • Deprecate some more aliases
  • News fragment

This avoids a warning when snapshotting an instrument without heater
These would confuse the parameter state its better to use the parameters
@jenshnielsen jenshnielsen requested a review from a team as a code owner August 2, 2024 09:44
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.20%. Comparing base (e7dd669) to head (4eb64a7).

Files Patch % Lines
...strument_drivers/american_magnetics/AMI430_visa.py 78.12% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6306   +/-   ##
=======================================
  Coverage   67.19%   67.20%           
=======================================
  Files         352      352           
  Lines       32154    32175   +21     
=======================================
+ Hits        21607    21622   +15     
- Misses      10547    10553    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen added this pull request to the merge queue Aug 5, 2024
@jenshnielsen jenshnielsen removed this pull request from the merge queue due to a manual request Aug 5, 2024
@trevormorgan trevormorgan added this pull request to the merge queue Aug 8, 2024
Merged via the queue into microsoft:main with commit a550eb5 Aug 8, 2024
17 checks passed
@jenshnielsen jenshnielsen deleted the ami_heater branch August 8, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants