Only warn on parameter overriding attribute if this is not a parameter #6211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overridding other atters would be a breaking change without warning
jenshnielsen
force-pushed
the
only_warn_on_attr
branch
from
8d7d7ee to
6953f99
Compare
astafan8
approved these changes
Jun 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6211 +/- ##
=======================================
Coverage 67.17% 67.17%
=======================================
Files 352 352
Lines 32128 32130 +2
=======================================
+ Hits 21582 21584 +2
Misses 10546 10546 ☔ View full report in Codecov by Sentry. |
jenshnielsen
added a commit
to jenshnielsen/Qcodes
that referenced
this pull request
Jun 28, 2024
Only warn on parameter overriding attribute if this is not a parameter
jenshnielsen
added a commit
that referenced
this pull request
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the error from #6174 a warning if the overridden attribute is not itself a parameter.