Driver bugfixes [Needs testing Keysight 34465 and Triton 450] #6076
Conversation
The total range is [0, 2**16 - 1] (0-based indexing). Previously, the maximum range value could not be set (e.g, 10 V in the [0, 10]V range).
convert_legacy_version_to_supported_version does not know how to handle the long tail my device returns.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6076 +/- ##
==========================================
- Coverage 67.61% 67.14% -0.47%
==========================================
Files 351 352 +1
Lines 30549 32121 +1572
==========================================
+ Hits 20656 21568 +912
- Misses 9893 10553 +660 ☔ View full report in Codecov by Sentry. |
|
@thangleiter Thanks for the contribution. I don't have access to test these but they seems sensible to me. Could you add a newsfragment as descripted in the pull request template. You will also need to run the precommit hooks to fix small formatting issues. |
|
@thangleiter FYI you don't need to worry about merging main into the branch. We will automatically test against latest main when merging |
jenshnielsen
changed the title
|
@thangleiter I changed the title to try to ask for testing a bit more clear. I will leave it for a few days before merging |
|
@thangleiter Lets go ahead and merge this. Can you fix the darker issue or give contributors access to push to your branch so I can fix it |
These are three small bugfixes on different drivers.
convert_legacy_version_to_supported_version, so it's chopped.It would be great if someone could verify the last two changes work on someone else's instruments.