-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept sequences of values for setting MultiChannelInstrumentParameter #6073
Merged
jenshnielsen
merged 9 commits into
microsoft:main
from
qutech:bugfix/multi_channel_instrument_parameter_setter
May 27, 2024
Merged
Accept sequences of values for setting MultiChannelInstrumentParameter #6073
jenshnielsen
merged 9 commits into
microsoft:main
from
qutech:bugfix/multi_channel_instrument_parameter_setter
May 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@microsoft-github-policy-service agree company="RWTH Aachen University" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6073 +/- ##
==========================================
+ Coverage 67.55% 67.65% +0.10%
==========================================
Files 351 352 +1
Lines 30492 30765 +273
==========================================
+ Hits 20598 20814 +216
- Misses 9894 9951 +57 ☔ View full report in Codecov by Sentry. |
thangleiter
commented
May 18, 2024
thangleiter
commented
May 19, 2024
jenshnielsen
approved these changes
May 27, 2024
thangleiter
deleted the
bugfix/multi_channel_instrument_parameter_setter
branch
January 17, 2025 16:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, the
MultiChannelInstrumentParameter
is inconsistent; its setter does not accept the values returned by its getter as the first accepts a scalarParamRawDataType
, but the last returns a tuple thereof. This is particularly problematic as it breaks theset_to
context manager.This proposed change modifies the setter to allow both the current scalar behavior as well as a sequence, in which case it is zipped together with
self._channels
.