-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CryomagneticsModel4G Power Supply Driver #5968
CryomagneticsModel4G Power Supply Driver #5968
Conversation
…rgan/Qcodes into trmorgan/cryo-4g-driver
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5968 +/- ##
==========================================
+ Coverage 67.52% 67.57% +0.04%
==========================================
Files 350 351 +1
Lines 30301 30471 +170
==========================================
+ Hits 20462 20591 +129
- Misses 9839 9880 +41 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @trevormorgan
I left some comments inline. Please also make sure to add the CryoMagnetics folder to the docs. under docs/driver_api
src/qcodes/instrument_drivers/cryomagnetics/Cryomagnetics4G_visa.py
Outdated
Show resolved
Hide resolved
src/qcodes/instrument_drivers/cryomagnetics/Cryomagnetics4G_visa.py
Outdated
Show resolved
Hide resolved
src/qcodes/instrument_drivers/cryomagnetics/Cryomagnetics4G_visa.py
Outdated
Show resolved
Hide resolved
src/qcodes/instrument_drivers/cryomagnetics/Cryomagnetics4G_visa.py
Outdated
Show resolved
Hide resolved
src/qcodes/instrument_drivers/cryomagnetics/Cryomagnetics4G_visa.py
Outdated
Show resolved
Hide resolved
src/qcodes/instrument_drivers/cryomagnetics/Cryomagnetics4G_visa.py
Outdated
Show resolved
Hide resolved
src/qcodes/instrument_drivers/cryomagnetics/Cryomagnetics4G_visa.py
Outdated
Show resolved
Hide resolved
…rgan/Qcodes into trmorgan/cryo-4g-driver
Co-authored-by: Jens Hedegaard Nielsen <[email protected]>
…rgan/Qcodes into trmorgan/cryo-4g-driver
src/qcodes/instrument_drivers/cryomagnetics/_cryomagnetics4g.py
Outdated
Show resolved
Hide resolved
@trevormorgan , and a news fragment would be great to add :) https://microsoft.github.io/Qcodes/community/contributing.html#pull-requests?highlight=newsfragments |
This Pull Request introduces the CryomagneticsModel4G
Summary of driver features:
Testing:
Complemented the new features with a suite of unit tests, ensuring robustness and reliability through extensive coverage.