Extend the Keysight N9030B with new parameters to allow noise measurement #5963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The frequency will automatically be shifted if the start is more than the stop or vice-versa. For setting up automated measurements, this is preferred so that we don't have to worry about previous settings.
astafan8
approved these changes
Apr 15, 2024
Co-authored-by: Jens Hedegaard Nielsen <[email protected]>
…thub.com/spauka/Qcodes into spauka/instrument/keysight_n9030b_extend
spauka
changed the title
jenshnielsen
approved these changes
Apr 22, 2024
spauka
force-pushed
the
spauka/instrument/keysight_n9030b_extend
branch
from
feb13a9 to
1d9d958
Compare
|
This is tested on a live instrument and seems to work well. Should be ready to merge but let me know if there are any additional comments. |
|
@spauka Looks like there is a test failure that needs to be addressed |
|
Looks like I need to add a few extra commands into the device sim class. I will fix tomorrow :) |
auto-merge was automatically disabled
April 23, 2024 01:41
Head branch was pushed to by a user without write access
…sight_n9030b_extend
spauka
force-pushed
the
spauka/instrument/keysight_n9030b_extend
branch
from
ae26190 to
c50e088
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5963 +/- ##
==========================================
+ Coverage 67.40% 67.42% +0.02%
==========================================
Files 349 349
Lines 30199 30201 +2
==========================================
+ Hits 20356 20364 +8
+ Misses 9843 9837 -6 ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@jenshnielsen This seems to have been an intermittent test failure not related to this PR. Can you requeue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a number of new parameters to the Keysight N9030B Spectrum Analyzer to allow for Noise Spectral Density measurements. In particular we add various parameters for switching the detectors into the appropriate modes, as well as allowing for instrument parameters required for unit conversions to be saved in the snapshot.
Specifically we add:
self.mech_attenuationself.preampself.preamp_enabledself.res_bw_typeself.res_bwself.video_bwself.detectorself.average_typeIn addition, a number of QOL improvements are made to the driver. This includes binary readout of the data and the ability to read data from the instrument buffer (without taking a new trace), and to read averaged data.
The public interface to the driver is extended but no breaking changes are made.
TODO: