Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements by Equal1 (station indexed param names; Rohde&Schwarz, Stahl, Stanford Research drivers) #5873

Closed
wants to merge 1 commit into from

Conversation

hp-peti
Copy link
Contributor

@hp-peti hp-peti commented Mar 20, 2024

  • Extended JSON schema and parser for Station files to allow indexing in instrument parameter name references
    • rationale: some drivers (ahem Zurich Instruments) only expose parameters through indexed access
  • Additional parameters for the Rohde & Schwarz SGS100A to support some expansion modules (pulse mod, trigger)
  • Fixed some issues with and improved the Stahl BS power source driver
    • regular expression did not cover all possible floating point values coming from the instrument
    • feature to access it over TCP/IP connection (e.g the serial port can be socat'd over a port -- solution not included)
  • a completely new Stanford Research SR570 driver based on SR560, but this one actually talks to the instrument

@hp-peti hp-peti requested a review from a team as a code owner March 20, 2024 09:52
@jenshnielsen
Copy link
Collaborator

@hp-peti Thanks for the contributions. I would like to request that you submit the new driver into the qcodes_contrib_drivers package here https://github.com/QCoDeS/Qcodes_contrib_drivers As none of the qcodes maintainers have acces to this instrument we prefer to add the instrument to that package as we cannot test and verify the driver

For the other contributions we would prefer if you can split them up into a pr for each of the drivers and one for the JSON/attribute fixes. This makes it easier to review and the changelog easier to follow both for users and maintainers. Let me know if this is possible for you.

@hp-peti hp-peti closed this Mar 25, 2024
@hp-peti hp-peti deleted the devel-0.44.1 branch March 25, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants