Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark non visa AMI driver as deprecated. #5712

Merged
merged 6 commits into from
Feb 5, 2024
Merged

mark non visa AMI driver as deprecated. #5712

merged 6 commits into from
Feb 5, 2024

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Feb 1, 2024 •
edited
Loading

The visa one is better supported and has fewer issues.

  • Add a deprecation notice
  • Silence warnings in tests

@jenshnielsen jenshnielsen requested a review from a team as a code owner February 1, 2024 14:09
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 1, 2024 14:09 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 1, 2024 14:09 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 1, 2024 14:09 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 1, 2024 14:09 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 1, 2024 14:09 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 1, 2024 14:09 — with GitHub Actions Inactive
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a35081) 67.55% compared to head (45d0f6b) 67.56%.
Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5712   +/-   ##
=======================================
  Coverage   67.55%   67.56%           
=======================================
  Files         348      348           
  Lines       30239    30247    +8     
=======================================
+ Hits        20427    20435    +8     
  Misses       9812     9812

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 1, 2024 14:48 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 1, 2024 14:48 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 1, 2024 14:48 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 1, 2024 14:48 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 1, 2024 14:48 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 1, 2024 14:48 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen force-pushed the deprecate_non_visa_ami_driver branch from 12a3a74 to 02c6cc0 Compare February 2, 2024 09:08
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 09:08 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 09:08 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 09:08 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 09:08 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 09:08 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 09:08 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 09:17 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 09:17 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 09:17 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 09:17 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 09:18 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 09:18 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 14:40 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 14:40 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 14:40 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 14:40 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 14:40 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 2, 2024 14:40 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 3, 2024 10:34 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 3, 2024 10:34 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 3, 2024 10:34 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 3, 2024 10:34 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 3, 2024 10:34 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen temporarily deployed to testing-environment February 3, 2024 10:34 — with GitHub Actions Inactive
@jenshnielsen jenshnielsen added this pull request to the merge queue Feb 5, 2024
Merged via the queue into microsoft:main with commit dd89f7c Feb 5, 2024
18 checks passed
@jenshnielsen jenshnielsen deleted the deprecate_non_visa_ami_driver branch February 5, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenshnielsen @astafan8