-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make loading from netcdf lazy using load_by_guid etc. #5711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:50 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:50 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:50 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:50 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:50 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:50 — with
GitHub Actions
Inactive
jenshnielsen
force-pushed
the
load_by_guid_lazy
branch
from
February 1, 2024 10:52
27d9df1
to
40282d1
Compare
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:53 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:53 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:53 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:53 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:53 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:53 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:57 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:57 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:57 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:57 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:57 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 10:57 — with
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5711 +/- ##
=======================================
Coverage 67.55% 67.55%
=======================================
Files 348 348
Lines 30244 30239 -5
=======================================
- Hits 20430 20427 -3
+ Misses 9814 9812 -2 ☔ View full report in Codecov by Sentry. |
astafan8
approved these changes
Feb 1, 2024
Co-authored-by: Mikhail Astafev <[email protected]>
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 13:52 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 13:52 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 13:52 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 13:52 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 13:52 — with
GitHub Actions
Inactive
jenshnielsen
temporarily deployed
to
testing-environment
February 1, 2024 13:52 — with
GitHub Actions
Inactive
jenshnielsen
added a commit
to jenshnielsen/Qcodes
that referenced
this pull request
Feb 1, 2024
Make loading from netcdf lazy using load_by_guid etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension to #5627 which also avoids loading the data from a netcdf file into qcodes format when loading the file using load_by_guid etc.