Make delayed/chunked export configurable and off by default #5618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5618 +/- ##
==========================================
- Coverage 66.39% 66.39% -0.01%
==========================================
Files 354 354
Lines 30966 30965 -1
==========================================
- Hits 20561 20560 -1
Misses 10405 10405 |
astafan8
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are unfortunately a few too many corner cases where this does not work well so leaving it off by default.
There may still be cases where this is useful so it can be enabled in those cases by temporarily setting the config. For now I have not added this as an option to the export method since it does not really seem to fit well in the api
TODO