Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarter selection of multi index export to xarray #5589

Merged
merged 6 commits into from
Dec 14, 2023

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Dec 11, 2023

  • Only automatically select multi index export if shapes are unset
  • Allow the user to select which export type to use
  • Tests?
  • Changelog

* Only automatically select multi index export shapes are unset
* Allow the user to select which export type to use
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #5589 (833a878) into main (61ee4b3) will increase coverage by 0.00%.
Report is 8 commits behind head on main.
The diff coverage is 94.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5589   +/-   ##
=======================================
  Coverage   66.39%   66.39%           
=======================================
  Files         354      354           
  Lines       30962    30965    +3     
=======================================
+ Hits        20556    20559    +3     
  Misses      10406    10406           

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think a test would be good idea - same dataset with auto/never values covered, so that also if anything changes on xarray/pandas side we can catch it.

src/qcodes/dataset/data_set.py Outdated Show resolved Hide resolved
@jenshnielsen
Copy link
Collaborator Author

jenshnielsen commented Dec 12, 2023

Testing plan

  • For a complete dataset on a grid without shapes set: Test that multiindex is used iff always always selected
  • For a complete dataset on grid with shape: The same
  • For a incomplete dataset on grid with shape: The same
  • For a dataset not on a grid: muitiindex: test multi index triggered iff always or auto
  • For an incomplte dataset on a grid: test multi index triggered iff always or auto

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful clear tests!

@jenshnielsen jenshnielsen added this pull request to the merge queue Dec 14, 2023
Merged via the queue into microsoft:main with commit b0ef240 Dec 14, 2023
15 of 16 checks passed
@jenshnielsen jenshnielsen deleted the smart_multi_index branch December 14, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants