-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smarter selection of multi index export to xarray #5589
Conversation
jenshnielsen
commented
Dec 11, 2023
•
edited
Loading
edited
- Only automatically select multi index export if shapes are unset
- Allow the user to select which export type to use
- Tests?
- Changelog
* Only automatically select multi index export shapes are unset * Allow the user to select which export type to use
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5589 +/- ##
=======================================
Coverage 66.39% 66.39%
=======================================
Files 354 354
Lines 30962 30965 +3
=======================================
+ Hits 20556 20559 +3
Misses 10406 10406 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think a test would be good idea - same dataset with auto/never values covered, so that also if anything changes on xarray/pandas side we can catch it.
Testing plan
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful clear tests!
Co-authored-by: Mikhail Astafev <[email protected]>