Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional blocking in Keithley 2450 #5547

Merged
merged 8 commits into from
Nov 24, 2023
Merged

Conversation

aaronsharpe
Copy link
Contributor

@aaronsharpe aaronsharpe commented Nov 22, 2023

Added a parameter to control whether or not ramp commands sent to Keithley 2450s block<!--

Thanks for submitting a pull request against QCoDeS.

To help us effectively merge your pr please consider the following check list.

  • Make sure that the pull request contains a short description of the changes made.
  • If you are submitting a new feature please document it. This can be in the form of inline
    docstrings, an example notebook or restructured text files.
  • Please include automatic tests for the changes made when possible.

Unless your change is a small or trivial fix please add a small changelog entry:

  • Create a file in the docs\changes\newsfragments folder with a short description of the change.

This file should be in the format number.categoryofcontribution. Here the number should either be the number
of the pull request. To get the number of the pull request one must
first the pull request and then subsequently update the number. The category of contribution should be
one of breaking, new, improved, new_driver improved_driver, underthehood.

If this fixes a known bug reported against QCoDeS:

  • Please include a string in the following form closes #xxx where ``xxx``` is the number of the bug fixed.

Please have a look at the contributing guide
for more information.

If you are in doubt about any of this please ask and we will be happy to help.

-->

@jenshnielsen jenshnielsen changed the title Optional blockign in Keithley 2450 Optional blocking in Keithley 2450 Nov 23, 2023
@jenshnielsen
Copy link
Collaborator

jenshnielsen commented Nov 23, 2023

Create a file in the docs\changes\newsfragments folder with a short description of the change.

Could you create a file called improved_driver.5547 as noted here with a description of the fix?

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #5547 (eb439f8) into main (faa0790) will decrease coverage by 0.01%.
Report is 29 commits behind head on main.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5547      +/-   ##
==========================================
- Coverage   66.32%   66.32%   -0.01%     
==========================================
  Files         354      354              
  Lines       30953    30958       +5     
==========================================
+ Hits        20530    20532       +2     
- Misses      10423    10426       +3     

@aaronsharpe
Copy link
Contributor Author

Added the requested changes. Sorry for missing the newsfragments doc!

@jenshnielsen jenshnielsen added this pull request to the merge queue Nov 24, 2023
Merged via the queue into microsoft:main with commit 8403882 Nov 24, 2023
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants