-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional blocking in Keithley 2450 #5547
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
changed the title
Optional blockign in Keithley 2450
Optional blocking in Keithley 2450
Nov 23, 2023
Could you create a file called improved_driver.5547 as noted here with a description of the fix? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5547 +/- ##
==========================================
- Coverage 66.32% 66.32% -0.01%
==========================================
Files 354 354
Lines 30953 30958 +5
==========================================
+ Hits 20530 20532 +2
- Misses 10423 10426 +3 |
Added the requested changes. Sorry for missing the newsfragments doc! |
jenshnielsen
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a parameter to control whether or not ramp commands sent to Keithley 2450s block<!--
Thanks for submitting a pull request against QCoDeS.
To help us effectively merge your pr please consider the following check list.
docstrings, an example notebook or restructured text files.
Unless your change is a small or trivial fix please add a small changelog entry:
This file should be in the format number.categoryofcontribution. Here the number should either be the number
of the pull request. To get the number of the pull request one must
first the pull request and then subsequently update the number. The category of contribution should be
one of
breaking
,new
,improved
,new_driver
improved_driver
,underthehood
.If this fixes a known bug reported against QCoDeS:
closes #xxx
where ``xxx``` is the number of the bug fixed.Please have a look at the contributing guide
for more information.
If you are in doubt about any of this please ask and we will be happy to help.
-->