Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Fix: Support for ivvi dac polarity and minor changes #541

Merged
merged 3 commits into from
Apr 24, 2017

Conversation

lukabavdaz
Copy link
Contributor

The main change proposed in this pull request is the functionality to set the polarity of the dacs when the instrument is intitialized. The validators of the dacs are modified to reflect the actual voltage range.

Minor changes include:

  • The "(mV)" in the label of the dacs was removed for being out of place (the "unit" string should store this information)
  • The function set_dacs_zero() has been modified to ramp the dacs according to the parameter settings by using the regular set function (Fixes issue Ivvi st_dacs_zero too fast #508)

@giulioungaretti

Also made the set_dacs_zero() function ramp using the set function and removed the excessive (mV) label for the dacs
@AdriaanRol
Copy link
Contributor

Maybe out of scope of this PR, but would it make sense to also solve #513 (a horrible syntax error by me) in this PR and change mV to V in the unit to be consistent with #494 ?

@lukabavdaz
Copy link
Contributor Author

I completely agree with fixing #513. Since it's such a small fix it should still be within the scope of the PR.

However, I'm hesitant to change the unit because it will break backwards compatibility. I suggest doing these kinds of changes in a more visible way (like associating them with a release) so everyone will know that code relying on the units needs to be updated.

@giulioungaretti giulioungaretti merged commit dfa0f4f into microsoft:master Apr 24, 2017
giulioungaretti pushed a commit that referenced this pull request Apr 24, 2017
Author: lukabavdaz <[email protected]>

    Feat: Fix: Support for ivvi dac polarity and minor changes (#541)
giulioungaretti pushed a commit that referenced this pull request Apr 24, 2017
Author: lukabavdaz <[email protected]>

    Feat: Fix: Support for ivvi dac polarity and minor changes (#541)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants