-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oxford Triton: Add control of pumps and temperature channels #5316
Merged
jenshnielsen
merged 19 commits into
microsoft:master
from
FredWolff:add_control_of_pumps_and_temperature_channels
Aug 24, 2023
Merged
Oxford Triton: Add control of pumps and temperature channels #5316
jenshnielsen
merged 19 commits into
microsoft:master
from
FredWolff:add_control_of_pumps_and_temperature_channels
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #5316 +/- ##
==========================================
- Coverage 67.63% 67.59% -0.04%
==========================================
Files 360 360
Lines 29987 30012 +25
==========================================
+ Hits 20283 20288 +5
- Misses 9704 9724 +20 |
for more information, see https://pre-commit.ci
jenshnielsen
changed the title
Add control of pumps and temperature channels
Oxford Triton: Add control of pumps and temperature channels
Aug 23, 2023
jenshnielsen
approved these changes
Aug 23, 2023
This was referenced Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the following parameters to the driver: pid_p, pid_i, pid_d, turb1_speed, turb1_state, comp_state and Tx_state where x represents the temperature channel id and runs from 1 to 17. The pid-parameters set and get the pid-values for the temperature controller. turb1_speed gets the speed of the turbo in Hz. The _state parameters get and set whether the pumps and temperature channels are on or off.