Update run_id when adding ds in mem to db #5209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dominik-Vogel Thanks. Looks like it is used in database_extract_runs.py see typechecking error. I think we should see if we can write a test for this too |
jenshnielsen
force-pushed
the
fix_run_id_dataset_in_mem
branch
from
b50fa29 to
c5096a1
Compare
Codecov Report
@@ Coverage Diff @@
## master #5209 +/- ##
==========================================
- Coverage 67.36% 67.34% -0.02%
==========================================
Files 359 359
Lines 29896 29901 +5
==========================================
- Hits 20138 20136 -2
- Misses 9758 9765 +7 |
jenshnielsen
force-pushed
the
fix_run_id_dataset_in_mem
branch
from
285c58b to
628b826
Compare
|
@Dominik-Vogel I have added tests and implemented the same fix for counter and exp_id. Could you have another look? |
astafan8
approved these changes
Jun 19, 2023
jenshnielsen
force-pushed
the
fix_run_id_dataset_in_mem
branch
from
14b60f5 to
270b302
Compare
This was referenced Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue of run_ids not getting incremented when importing netcdf datasets or datasets in memory in general.
Addressing the issue we have talked about @jenshnielsen .
I have replaced the table name return value, as I could not find it used anywhere and it is not a part of a public API.