Multiparameter fixes #512
Merged
Multiparameter fixes #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compared to the other prs this adds tests and removes an unwanted assert otherwise identical |
|
LGTM @jenshnielsen, rebase onto master then squash and merge at will! |
jenshnielsen
force-pushed
the
multiparameter_fixes
branch
from
6cfeb28
to
adbf58a
Compare
giulioungaretti
approved these changes
Mar 7, 2017
giulioungaretti
pushed a commit
that referenced
this pull request
Mar 7, 2017
Author: Jens Hedegaard Nielsen <[email protected]> Multiparameter fixes (#512)
giulioungaretti
pushed a commit
that referenced
this pull request
Mar 8, 2017
Author: Jens Hedegaard Nielsen <[email protected]> Multiparameter fixes (#512)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@QCoDeS/core
This replaces #500 #501 and #502
Simpler to do in one as the tests are strongly coupled