Add ability to lookup component in station by full name #5028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5028 +/- ##
==========================================
+ Coverage 67.22% 67.31% +0.08%
==========================================
Files 357 357
Lines 29735 29839 +104
==========================================
+ Hits 19989 20085 +96
- Misses 9746 9754 +8 |
astafan8
approved these changes
Feb 21, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
And ensure that all components implements this so we can safely use short_name and full_name on all components in a station
In station and in instrumentbase so we can get a component by its full name
jenshnielsen
force-pushed
the
add_station_lookup
branch
from
48580d9 to
ff01272
Compare
jenshnielsen
force-pushed
the
add_station_lookup
branch
from
084f93d to
5ef451a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is handy since you can then look up any parameter from its name in the snapshot.
Slightly complicated by the fact that a name could it self contain
_we handle that by trying to merge the next name_part into the name that we are trying to lookup if the name cannot be found but we do not try to handle all possibilities. E.g. it is possible for the complete name to not be uniqueTo make this possible change the baseclass of all components to have short_name and full_name properties