-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework config fixtures #4906
Merged
jenshnielsen
merged 15 commits into
microsoft:master
from
jenshnielsen:always_set_config
Oct 2, 2023
Merged
Rework config fixtures #4906
jenshnielsen
merged 15 commits into
microsoft:master
from
jenshnielsen:always_set_config
Oct 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
force-pushed
the
always_set_config
branch
2 times, most recently
from
January 9, 2023 10:20
d4c89e8
to
c700045
Compare
jenshnielsen
force-pushed
the
always_set_config
branch
from
January 9, 2023 12:30
38e2bd5
to
2d88be7
Compare
Codecov Report
@@ Coverage Diff @@
## master #4906 +/- ##
=======================================
Coverage 68.24% 68.24%
=======================================
Files 341 341
Lines 29901 29901
=======================================
Hits 20405 20405
Misses 9496 9496 |
jenshnielsen
force-pushed
the
always_set_config
branch
3 times, most recently
from
September 30, 2023 05:17
416c4be
to
ff81995
Compare
jenshnielsen
changed the title
Always set default config in the tests
Always reset config on exit of tests
Sep 30, 2023
jenshnielsen
changed the title
Always reset config on exit of tests
Rework config fixtures
Sep 30, 2023
This is fixes issues where modules that had already imported config as from qcodes import config would not work with the fixture since the module is imported before its replaced.
We are anyway overwriting the location so it will never be the current dir
jenshnielsen
force-pushed
the
always_set_config
branch
from
September 30, 2023 09:53
ca96e6d
to
0ebb228
Compare
jenshnielsen
commented
Sep 30, 2023
astafan8
approved these changes
Oct 2, 2023
Dominik-Vogel
approved these changes
Oct 2, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace existing config fixtures with 2 auto use fixtures.
Since these are auto use we can remove all explicit use of config fixtures.
In the process fix some issues.
from qcodes import config
so instead patch the existing config object.