-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor types to check with pyright #4894
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4894 +/- ##
==========================================
- Coverage 68.32% 67.40% -0.92%
==========================================
Files 340 340
Lines 32157 32236 +79
==========================================
- Hits 21970 21729 -241
- Misses 10187 10507 +320 |
jenshnielsen
force-pushed
the
pyright_1
branch
from
January 3, 2023 08:08
5caae44
to
39fae99
Compare
jenshnielsen
commented
Jan 3, 2023
jenshnielsen
commented
Jan 3, 2023
astafan8
reviewed
Jan 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks nice! some of the found things are indeed well-found bugs!
jenshnielsen
force-pushed
the
pyright_1
branch
from
January 3, 2023 12:17
c0f14b1
to
b07107a
Compare
Ipython became typed in #4897 so those stubs should be removed |
jenshnielsen
force-pushed
the
pyright_1
branch
2 times, most recently
from
January 3, 2023 15:21
c3e5476
to
eb4f9d1
Compare
jenshnielsen
commented
Jan 4, 2023
Pointed out by pyright
It seems like pyright does not like pass
for more information, see https://pre-commit.ci
Co-authored-by: Mikhail Astafev <[email protected]>
jenshnielsen
force-pushed
the
pyright_1
branch
from
January 4, 2023 09:10
eb4f9d1
to
1cfe3a0
Compare
jenshnielsen
changed the title
[WIP] Refactor types to check with pyright
Refactor types to check with pyright
Jan 4, 2023
astafan8
approved these changes
Jan 4, 2023
Co-authored-by: Mikhail Astafev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over Christmas I spent a bit of time experimenting with getting types to check with pyright in addition to mypy
This is mainly motivated by having typechecking inline in vscode
There are a number of differences.