Add the option to set pulse modulation in the Keysight N51x1 signal generators
#4840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4840 +/- ##
==========================================
- Coverage 68.30% 68.29% -0.01%
==========================================
Files 339 339
Lines 32123 32126 +3
==========================================
Hits 21942 21942
- Misses 10181 10184 +3 |
|
@bguttel Thanks, looks good. Could you create a file at /docs/changes/news_fragments/4840.improved_driver with a short description of the fix so it makes it into the changelog |
Documentation of the pulse modulation parameters
Added the file. |
jenshnielsen
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice that there are two parameters there, one that sets the general state of the pulse modulation (boolean) and one that sets whether it will be 'internal' or 'external'.
Not all the signal generators come with this feature so I added an
ifcondition to test for it.