Allow pyvisa-sim instrs to be loaded from yaml file #4789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs a bit of special handling to allow us to lookup the file relative to qcodes location
Codecov Report
@@ Coverage Diff @@
## master #4789 +/- ##
==========================================
+ Coverage 68.20% 68.23% +0.02%
==========================================
Files 339 339
Lines 32043 32050 +7
==========================================
+ Hits 21856 21869 +13
+ Misses 10187 10181 -6 |
3 tasks
|
closed in favour of #4790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it simpler to write examples of station yaml files that makes use of pyvisa-sim instruments
The visalib argument to the driver needs to have the full path to the sim file so it is not practical to put in the file in a portable way. As a workaround, I have added a different argument that allows the users to supply the name of the file which is then looked up in the default bundled location. Happy for other suggestions to how this could be done
In the process I have added logic to allow the loading of a pyvisa-sim yaml file using importlib-resources in the recommended portable way.
TODO
__file__hack