Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ATS9440.py to fix the 'ABCD' value mapping #3802

Merged
merged 3 commits into from
Jan 10, 2022
Merged

Update ATS9440.py to fix the 'ABCD' value mapping #3802

merged 3 commits into from
Jan 10, 2022

Conversation

gdeboo
Copy link
Contributor

@gdeboo gdeboo commented Jan 10, 2022

'ABCD' value mapping should be the bitwise or of 0x00000001 | 0x00000002 | 0x00000004 | 0x00000008, which is 15

@gdeboo
Update ATS9440.py to fix a value
a63a907 
'ABCD' value mapping should be the bitwise or of 0x00000001 | 0x00000002 | 0x00000004 | 0x00000008, which is 15
@codecov
Copy link

codecov bot commented Jan 10, 2022 •
edited
Loading

Codecov Report

Merging #3802 (83bba40) into master (353d6d8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3802   +/-   ##
=======================================
  Coverage   65.72%   65.72%           
=======================================
  Files         226      226           
  Lines       30528    30528           
=======================================
  Hits        20064    20064           
  Misses      10464    10464

@gdeboo
Update the value mapping of the channel selection
92ac8e5 
A = 0x00000001
B = 0x00000002
C = 0x00000004
D = 0x00000008
A | B = 3
A | C = 5
B | C = 6
A | D = 9
B | D = 10
C | D = 12
@jenshnielsen
Copy link
Collaborator

@gdeboo Thanks for the fix. Could you add a changelog entry as described in the pr template ?

  • Create a file in the docs\changes\newsfragments folder with a short description of the change.

This file should be in the format number.categoryofcontribution. Here the number should either be the number
of the pull request. To get the number of the pull request one must
first the pull request and then subsequently update the number. The category of contribution should be
one of breaking, new, improved, new_driver improved_driver, underthehood.

@jenshnielsen jenshnielsen added this to the 0.32.0 milestone Jan 10, 2022
@jenshnielsen
Copy link
Collaborator

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 10, 2022

👎 Rejected by too few approved reviews

@jenshnielsen
Copy link
Collaborator

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 10, 2022

Build succeeded:

@bors bors bot merged commit a41db74 into microsoft:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenshnielsen jenshnielsen jenshnielsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.32.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdeboo @jenshnielsen