Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup import: disable ipython magic by default #3764

Merged
merged 6 commits into from
Jan 4, 2022
Merged

Speedup import: disable ipython magic by default #3764

merged 6 commits into from
Jan 4, 2022

Conversation

jenshnielsen
Copy link
Collaborator

This changes the configuration such that the legacy IPython magic becomes off by default. Avoiding to unconditionally import IPython on startup. This saves ~ 0.3/4 sec or so

@jenshnielsen
Copy link
Collaborator Author

This should get a breaking change entry

@codecov
Copy link

codecov bot commented Jan 3, 2022 •
edited
Loading

Codecov Report

Merging #3764 (bd01afd) into master (a00867d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3764      +/-   ##
==========================================
- Coverage   65.68%   65.67%   -0.01%     
==========================================
  Files         226      226              
  Lines       30581    30582       +1     
==========================================
  Hits        20086    20086              
- Misses      10495    10496       +1

@jenshnielsen jenshnielsen changed the title Speedup/ipython magic off by default Speedup import: disable ipython magic off by default Jan 3, 2022
@jenshnielsen jenshnielsen changed the title Speedup import: disable ipython magic off by default Speedup import: disable ipython magic by default Jan 3, 2022
astafan8
astafan8 approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support and agree :)

This should get a breaking change entry

yes

@jenshnielsen
Copy link
Collaborator Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 4, 2022

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@jenshnielsen
Copy link
Collaborator Author

bors merge

1 similar comment
@jenshnielsen
Copy link
Collaborator Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 4, 2022

Already running a review

@bors
Copy link
Contributor

bors bot commented Jan 4, 2022

Build succeeded:

@bors bors bot merged commit d7e8c4c into microsoft:master Jan 4, 2022
@jenshnielsen jenshnielsen deleted the speedup/ipython_magic_off_by_default branch January 4, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

Assignees
No one assigned
Labels
speedup_import
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenshnielsen @astafan8