Avoid calculating version twice on startup #3762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is already statically avaliable as qcodes.__version__
jenshnielsen
changed the title
|
Note that this is technically an api break as qcodes.version used to be a valid module after importing qcodes (since the data array module pulled it in) without explicitly importing it. That is no longer the case |
|
We should perhaps give this a breaking change entry |
Codecov Report
@@ Coverage Diff @@
## master #3762 +/- ##
==========================================
- Coverage 65.68% 65.66% -0.02%
==========================================
Files 226 226
Lines 30581 30583 +2
==========================================
- Hits 20086 20082 -4
- Misses 10495 10501 +6 |
astafan8
approved these changes
Jan 4, 2022
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is already statically avaliable as
qcodes.__version__This shaves of 0.3 sec or so from the start up time.
It may be worthwile deprecating the version module. However #3731 fixes this anyway in a way that ensures version is only calculated once per session