Feature/qt plot

[MerlinSmiles]

Fixes the Qt part of #266
Fixes #259 I think
Fixes the Qt part of #217
Fixes #34 since setGeometry is now directly available and _repr_png_ exists
Fixes #289 I implemented it here too...

Changes proposed in this pull request:

• Use pyqtgraph Docks for subplots
• Expose some of the Dock-functionality to QtPlot.add()
• Add transpose argument to QtPlot.add() (flip x, y axes, and transpose z)
• Fix plotting when x, y, z datasets are defined
• Remove Javascript update widget which is only used for update timing, replaced with native Qt timer
• Add PNG representation of the plot windows
• Add plotting tutorial
• Add get default array title currently the location and array_id, maybe it should be reduced to the name and array_id, in the case where name exists. however, location is nice to later relate screenshots to the right dataset.
• Add get_units
• renamped update to update_data in base.py so it wont interfere with update() from the Qwidget
• removed pyqtgraph remote plotting stuff

I'm leaving for a holiday now, but it would be great if someone could check this over, and give some input

This PR is mostly meant to fix some of the urgent issues I came across, there is still a lot to do but for that we need to refactor the whole plotting system, which seems somewhat complicated right now. Make it more modular and allow for easy additions...

@giulioungaretti @alexcjohnson @AdriaanRol @peendebak @nataliejpg

[qcodes-bot]

Current coverage is 88.00% (diff: 100%)

No coverage report found for master at e76f95b.

Powered by Codecov. Last update e76f95b...b428c98

[MerlinSmiles]

I forgot to mention that this plot is now a QtWidget, which allows to integrate it in other qt guis easily...

[eendebakpt]

Just tested the PR and it works fine on my system. I took the liberty of adding part of my own additions to QtPlot: copying a figure to the system clipboard.

[MerlinSmiles]

Great idea, what system are you using?
If I remember right I had problems with this clipboard stuff on windows, when the window was in the background...
Also for the naming maybe copy_to_clipboard would fit better? I have the feeling we should stick to qcodes style even though Qt does the other thing.

[eendebakpt]

Some minor issues:

• We might want to use qtpy (https://pypi.python.org/pypi/QtPy) to select the Qt interface. PyQt4 is pretty standard, but people also use PySide or PyQt5
• Going from windowTitle to windowtitle makes the PR not backwards compatible. I just searched for a style-guide on function arguments in qcodes, but could not find it. One of the other arguments is show_window. I suggest we either use (showwindow, windowtitle) or (show_window, window_title), but no other combination

[MerlinSmiles]

Good points!
yes I was struggling with those argument names, its really annoying if one package uses one style and another one another style, and if it basically just passes through... and then I just get it messed up.

As for QtPy, I never tried it, but it might be a good idea. I remember though having problems with PySide, and PyQtgraph wont work with PyQt5 I think. But yes, that shouldnt stop us from doing it right.

[eendebakpt]

System is ubuntu 16.04, but our measurement system is windows, so we'll need that one as well (I can test next week). I agree using qcodes style is the right thing to do.

[MerlinSmiles]

And thanks for testing this!

[CJvanDiepen]

@MerlinSmiles The dockarea .clear() function is not in 0.9.10 (the default installed by anaconda)
This gives an error when runnin the QtPlot.clear().

The commit for pyqtgraph is here:

pyqtgraph/pyqtgraph@76dbdaf

[CJvanDiepen]

Also Dock.setTitle was only added later:

pyqtgraph/pyqtgraph@138fbb7

To solve the issues one can install a more recent version of pyqtgraph:

conda install -c nmearl pyqtgraph=0.9.11

[eendebakpt]

Deze regel: https://github.com/qdev-dk/Qcodes/pull/290/files#diff-4e71a3e969fcdacead1806f2d8a6afd7R140
is denk ik enkel python 3.5. Zie http://legacy.python.org/dev/peps/pep-0448/

[lgnjanssen]

@eendebakpt I can confirm. This solved it for me in python 3.4.5
geometry_settings = itertools.chain(figposition,figsize)
self.setGeometry(*geometry_settings)

[giulioungaretti]

@MerlinSmiles 🍻 +review ?

[peendebak]

@giulioungaretti @MerlinSmiles Any news on this PR?

[giulioungaretti]

@MerlinSmiles kwargs? Am I missing something?

[giulioungaretti]

@MerlinSmiles which version of py qt graph are you using ? the last release is 0.9.10

[giulioungaretti]

actually, let's all wait until pyqtgraph/pyqtgraph#377 is closed and v 0.10.0 is released !

[WilliamHPNielsen]

I am closing this PR and deleting the branch after testimonies from Giulio and Merlin that this is nukeable.