Station: fail hard when adding an Instrument with a name that is already registered
#1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general I agree. We could consider deprecating make_unique for now and remote it later |
Codecov Report
@@ Coverage Diff @@
## master #1714 +/- ##
==========================================
- Coverage 67.25% 67.21% -0.05%
==========================================
Files 145 145
Lines 17949 17951 +2
==========================================
- Hits 12072 12066 -6
- Misses 5877 5885 +8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when adding an instrument to the
Stationwith a name that has already been taken, the instrument will be renamed bymake_unique.This behavior is, imho, not acceptable, because the instrument name is the best inter process identifier for instruments that we have. Therefore the name may not change silently from the specified name.
This PR removes
make_uniqueand raises an error if a name is already taken.Warning: this might break existing scripts!