CI: Link commands in all scripts by their exit code, use mostly 'bash' #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there have been cases where within a bash or script step one command would fail with non-0 exit code but the command after that would continue to execute. we are trying to prevent this from happening
Codecov Report
@@ Coverage Diff @@
## master #1712 +/- ##
==========================================
- Coverage 67.22% 67.21% -0.01%
==========================================
Files 145 145
Lines 17951 17951
==========================================
- Hits 12067 12066 -1
- Misses 5884 5885 +1 |
WilliamHPNielsen
changed the title
... also format that command for readability
astafan8
changed the title
|
@jenshnielsen could you have a look again ? after that we can press "update branch", ensure that everything ends with green, and squash-merge it. |
|
@jenshnielsen is this good to go? |
astafan8
deleted the
azure-pipelines/respect-exit-code-within-scripts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been cases where within a
bashorscriptstep one command would fail with non-0 exit code but the command after that would continue to execute. This is not desired because, for example, we don't want to runmypyif the"qcodes"environment wasn't activated.In this PR, we use
&&to glue commands together so that non-0 exit code prevents continuation of execution of a command sequence. Moreover, most of thescriptsteps got converted tobashsteps.