dev / add logging to measurement runner __exit__ #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamHPNielsen
changed the title
WilliamHPNielsen
force-pushed
the
dev/add_logging_to_measurement_end
branch
from
0c8512d to
7d70326
Compare
Codecov Report
@@ Coverage Diff @@
## master #1695 +/- ##
==========================================
+ Coverage 67.23% 67.23% +<.01%
==========================================
Files 145 145
Lines 17939 17946 +7
==========================================
+ Hits 12061 12066 +5
- Misses 5878 5880 +2 |
Codecov Report
@@ Coverage Diff @@
## master #1695 +/- ##
==========================================
- Coverage 67.26% 67.25% -0.01%
==========================================
Files 145 145
Lines 17939 17946 +7
==========================================
+ Hits 12066 12070 +4
- Misses 5873 5876 +3 |
Co-Authored-By: Mikhail Astafev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does what @astafan8 suggested in #1668 😄
Changes proposed in this pull request:
__exit__method of theMeasurementRunnerI opted for just stuffing in the traceback, as I think human-readability is probably to be favoured over some structured view of the error chain. We can change or extend this later as needed.
@QCoDeS/core